Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth #1

Merged
merged 23 commits into from
Jun 23, 2021
Merged

Auth #1

merged 23 commits into from
Jun 23, 2021

Conversation

MikeDrewitt
Copy link
Member

@MikeDrewitt MikeDrewitt commented Jun 13, 2021

Proposed changes


Added some type changes and utils while adding Auth to API (and client

Required API PR - UBAutograding/devU-api#12
Client PR - UBAutograding/devU-client#3

Types of changes


  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist


  • My changeset covers only what is described above (no extraneous changes)
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged downstream

Further comments


N/A

src/types/auth.types.ts Show resolved Hide resolved
src/utils/tests/object.utils.test.ts Outdated Show resolved Hide resolved
@daviddob daviddob merged commit 4bb601d into master Jun 23, 2021
@daviddob daviddob deleted the auth branch June 23, 2021 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants