Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added verbose option for check_pop_data. #173

Merged
merged 2 commits into from
Jul 10, 2024
Merged

added verbose option for check_pop_data. #173

merged 2 commits into from
Jul 10, 2024

Conversation

d-morrison
Copy link
Member

@d-morrison d-morrison commented Jul 9, 2024

Added verbose option for check_pop_data(), changing default behavior
to avoid printing an OK message.
Silences an unneeded console message unless specifically requested.

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files Coverage Δ
R/check_pop_data.R 46.15% <0.00%> (-7.70%) ⬇️

@d-morrison d-morrison requested a review from chrisorwa July 9, 2024 19:30
@d-morrison
Copy link
Member Author

codecov went down, but I created an issue to add tests: #174

@d-morrison d-morrison added this to the v2.0 release milestone Jul 9, 2024
Copy link
Collaborator

@chrisorwa chrisorwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@chrisorwa chrisorwa merged commit 56f56a8 into main Jul 10, 2024
9 checks passed
@d-morrison d-morrison deleted the silent-checks branch July 17, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants