-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cran fixes #221
base: main
Are you sure you want to change the base?
Cran fixes #221
Changes from 55 commits
52f8ae1
9e6ae3d
afe705e
012dcaf
e881172
134602d
39bff66
720f528
ff58791
591c778
e45dd9a
2c0e8c8
5053f19
8b9f395
0cb57cd
1c5c491
f43f498
e18e3f0
e0a5e65
3018f56
5528632
a0acf5d
285163a
f0c9c67
801d719
85d4e84
c859481
246c52c
6a8c62d
25d2934
1b1d460
918a951
ac4283c
9afdcb4
83d50b6
b96c804
530b4d3
5fce1b1
cfa3ba5
5b0c0be
5b91bd4
29cf05f
e32f000
3cc2930
64f38ab
4d50ded
709cfbe
8718b80
b09b41a
1fe1d0f
0c8727c
0120df7
953f68b
f129505
ebc0ff0
6a1ce23
49f6c61
24e92b5
dec4e25
5283f42
84b0d10
30fcc8b
6f036b7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
Version: 1.0.0 | ||
Date: 2024-03-12 23:48:24 UTC | ||
SHA: 9feb9f5f1965fd7b48031b941d6570bde33f538b | ||
Version: 1.0.3 | ||
Date: 2024-07-18 19:00:17 UTC | ||
SHA: 4d50ded599f4b61cd0d1e784f008aef30ec6462b |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,14 @@ | ||
Package: serocalculator | ||
Type: Package | ||
Title: Estimating Infection Rates from Serological Data | ||
Version: 1.2.0.9000 | ||
Version: 1.0.3 | ||
Authors@R: c( | ||
person(given = "Peter", family = "Teunis", email = "[email protected]", role = c("aut", "cph"), comment = "Author of the method and original code."), | ||
person(given = "Kristina", family = "Lai", email = "[email protected]", role = c("aut", "cre")), | ||
person(given = "Chris", family = "Orwa", role = "aut"), | ||
person(given = "Kristen", family = "Aiemjoy", email = "[email protected]", role = c("aut")), | ||
person(given = "Douglas Ezra", family = "Morrison", email = "[email protected]", role = c("aut"))) | ||
Description: Translates antibody levels measured in cross-sectional population | ||
samples into estimates of the frequency with which seroconversions (infections) | ||
occur in the sampled populations. Replaces the previous `seroincidence` package. | ||
Description: Translates antibody levels measured in cross-sectional population samples into estimates of the frequency with which seroconversions (infections) occur in the sampled populations. Replaces the previous 'seroincidence' package. Methods originally published in Simonsen et al. (2009) <doi:10.1002/sim.3592> and Teunis et al. (2012) <doi:10.1002/sim.5322>, and further developed in subsequent publications by de Graaf et al. (2014) <doi:10.1016/j.epidem.2014.08.002>, Teunis et al. (2016) <doi:10.1016/j.epidem.2016.04.001>, and Teunis et al. (2020) <doi:10.1002/sim.8578>. | ||
Comment on lines
-12
to
+11
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added in links to key citations in the format suggested by CRAN There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
Depends: R (>= 4.1.0) | ||
License: GPL-3 | ||
Imports: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated with newest changes and added sections for published and development versions |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,19 +10,21 @@ | |
#' @return a [ggplot2::ggplot()] object | ||
#' @export | ||
#' @examples | ||
#' \donttest{ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'll approve the use of |
||
#' library(dplyr) | ||
#' library(ggplot2) | ||
#' library(magrittr) | ||
#' | ||
#' curve = load_curve_params("https://osf.io/download/rtw5k/") %>% | ||
#' filter(antigen_iso %in% c("HlyE_IgA", "HlyE_IgG")) %>% | ||
#' slice(1:100, .by = antigen_iso) %>% # Reduce dataset for the purposes of this example | ||
#' autoplot() | ||
#' | ||
#' curve | ||
#' | ||
#'} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added missing closing bracket |
||
autoplot.curve_params = function( | ||
object, | ||
antigen_isos = object$antigen_iso %>% unique(), | ||
antigen_isos = unique(object$antigen_iso), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated style to avoid pipe within an argument definition There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fine by me; for future reference, is this a CRAN rule, a style guide rule, or just a choice we made? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe this was a CRAN rule, but I haven't found it to be sure. Will update if I find it. |
||
ncol = min(3, length(antigen_isos)), | ||
...) { | ||
split_data <- object %>% | ||
|
kristinawlai marked this conversation as resolved.
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did the version number go backwards?