Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve autoplot.pop_data error communication #234

Merged
merged 58 commits into from
Oct 15, 2024

Conversation

chrisorwa
Copy link
Collaborator

No description provided.

@chrisorwa chrisorwa linked an issue Aug 12, 2024 that may be closed by this pull request
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
R/autoplot.pop_data.R 96.55% 1 Missing ⚠️
Files with missing lines Coverage Δ
R/autoplot.pop_data.R 71.68% <96.55%> (+71.68%) ⬆️

DESCRIPTION Outdated Show resolved Hide resolved
NEWS.md Show resolved Hide resolved
R/autoplot.pop_data.R Show resolved Hide resolved
R/autoplot.pop_data.R Outdated Show resolved Hide resolved
R/autoplot.pop_data.R Outdated Show resolved Hide resolved
R/autoplot.pop_data.R Outdated Show resolved Hide resolved
vignettes/articles/scrubTyphus_example.Rmd Outdated Show resolved Hide resolved
vignettes/articles/scrubTyphus_example.Rmd Show resolved Hide resolved
vignettes/articles/scrubTyphus_example.Rmd Outdated Show resolved Hide resolved
vignettes/articles/scrubTyphus_example.Rmd Show resolved Hide resolved
vignettes/articles/scrubTyphus_example.Rmd Show resolved Hide resolved
Copy link
Member

@d-morrison d-morrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this PR! The package installation instructions still weren't quite what I thought they should be, so I wrote a patch PR here: #305. I ended up removing the installation details entirely and just linking to the installation instructions pages provided by each package.

Please review closely, and let me know if you have any questions.

Copy link

github-actions bot commented Oct 15, 2024

📕 Preview documentation for this PR has been cleaned up.

Copy link
Member

@d-morrison d-morrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR - looks good to me!

@d-morrison d-morrison merged commit 515ca4f into main Oct 15, 2024
16 checks passed
@d-morrison d-morrison deleted the improve-autoplotpop_data-error-communication branch October 15, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve autoplot.pop_data() error communication
2 participants