Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicate reason for pod failures leading to Faulted #111

Merged
merged 5 commits into from
Jun 1, 2024
Merged

Indicate reason for pod failures leading to Faulted #111

merged 5 commits into from
Jun 1, 2024

Conversation

ryescholin
Copy link
Member

@ryescholin ryescholin commented Jun 1, 2024 •
edited by taesungh
Loading

Resolves #106.

taesungh
taesungh reviewed Jun 1, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding, some suggestions on the message format.

control-station/src/services/PodSocketClient.ts Outdated Show resolved Hide resolved
pod-operation/src/state_machine.rs Outdated Show resolved Hide resolved
taesungh
taesungh approved these changes Jun 1, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for now. As I mentioned in the original issue, perhaps it would be better to enumerate the messages for reduced bandwidth, but not a huge concern right now.

@ryescholin ryescholin merged commit 8a90245 into main Jun 1, 2024
2 checks passed
@taesungh taesungh mentioned this pull request Jun 1, 2024
Closed
@taesungh taesungh deleted the failures branch June 1, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taesungh taesungh taesungh approved these changes

@vrushang1234 vrushang1234 vrushang1234 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Indicate reason for pod failures leading to Faulted
3 participants
@ryescholin @taesungh @vrushang1234