Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamics #114

Closed
wants to merge 7 commits into from
Closed

Dynamics #114

wants to merge 7 commits into from

Conversation

vrushang1234
Copy link
Contributor

Added react router and dynamics page

Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing parts of #112 mixed in here. Please separate out changes specific to your PR. Additionally, please make sure to define the scope of your work in a proper issue description. Adding React Router is a bit of a surprise to us and could have been discussed beforehand.

@vrushang1234 vrushang1234 deleted the dynamics branch June 1, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants