Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement orientation measurement from gyroscope #51

Merged
merged 7 commits into from
May 24, 2024
Merged

Implement orientation measurement from gyroscope #51

merged 7 commits into from
May 24, 2024

Conversation

vrushang1234
Copy link
Contributor

@vrushang1234 vrushang1234 commented May 14, 2024 •
edited
Loading

Added the code for gyroscope to find the roll and pitch using an inbuilt function for the MPU6050 in Rust. For issue #29

taesungh
taesungh requested changes May 15, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, some small suggestions on making usage more clear.

pod-operation/src/main.rs Outdated Show resolved Hide resolved
pod-operation/src/main.rs Outdated Show resolved Hide resolved
pod-operation/src/components/gyro.rs Outdated Show resolved Hide resolved
pod-operation/src/components/gyro.rs Outdated Show resolved Hide resolved
@taesungh taesungh changed the title Added the gyroscope code in pod-operation Implement orientation measurement from gyroscope May 18, 2024
@samderanova samderanova requested a review from taesungh May 18, 2024 21:20
@taesungh taesungh linked an issue May 18, 2024 that may be closed by this pull request
[Pod] Implement inertial measurements from gyroscope via I2C #29
Closed
taesungh
taesungh reviewed May 22, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase your changes with the latest main branch again, there are still merge conflicts.

pod-operation/src/components/gyro.rs Outdated Show resolved Hide resolved
taesungh
taesungh approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning that up, will be squashing during merge.

@taesungh taesungh merged commit eb3ce7d into main May 24, 2024
2 checks passed
This was referenced May 25, 2024
Closed
Closed
@taesungh taesungh deleted the gyro branch June 2, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samderanova samderanova samderanova approved these changes

@taesungh taesungh taesungh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Pod] Implement inertial measurements from gyroscope via I2C
3 participants
@vrushang1234 @samderanova @taesungh