Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Jupyter notebook page. #157

Merged
merged 8 commits into from
Oct 24, 2023
Merged

Add a Jupyter notebook page. #157

merged 8 commits into from
Oct 24, 2023

Conversation

samcunliffe
Copy link
Member

@samcunliffe samcunliffe commented Aug 30, 2023

Putting my best linters found so far. Does not completely solve #49.

Anyone with experience linting jupyter notebooks is very welcome to review.

Putting my best linters found so far. Does not completely solve #49.
@samcunliffe samcunliffe force-pushed the sc/49-start-jupyter-page branch from d71ddcc to 7c4e215 Compare August 31, 2023 06:17
@samcunliffe samcunliffe marked this pull request as ready for review September 29, 2023 10:12
@samcunliffe samcunliffe added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 29, 2023
@p-j-smith
Copy link
Contributor

I've never done linting of notebooks so not much help here, but when you say:

Does not completely solve #49.

do you know what else needs to be done to close the issue?

Copy link
Collaborator

@matt-graham matt-graham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me other than I would personally caveat the recommendation to favour Python modules a bit as I feel notebooks do have valid use cases.

docs/pages/jupyter-notebooks.md Outdated Show resolved Hide resolved
@samcunliffe samcunliffe merged commit 1a95d21 into main Oct 24, 2023
7 checks passed
@samcunliffe samcunliffe deleted the sc/49-start-jupyter-page branch October 24, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants