Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre-commit hook charliermarsh/ruff-pre-commit to v0.0.291 #166

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Update pre-commit hook charliermarsh/ruff-pre-commit to v0.0.291 #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b404c29
Update pre-commit hook charliermarsh/ruff-pre-commit to v0.0.291
renovate[bot] Sep 26, 2023
165c1a7
Explicitly set `check=False`
paddyroddy Sep 26, 2023
9bdc2f1
Can't have `branch` and `branch-ignore`
paddyroddy Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/links.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ on:
- main
- "renovate/**"
pull_request:
branches-ignore:
- "renovate/**"

jobs:
link-checker:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/linting.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- main
- "renovate/**"
pull_request:
branches-ignore:
- "renovate/**"

jobs:
lint-this-repo:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
- main
- "renovate/**"
pull_request:
branches-ignore:
- "renovate/**"

jobs:
test-template:
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
repos:
- repo: https://github.com/charliermarsh/ruff-pre-commit
rev: v0.0.284
rev: v0.0.291
hooks:
- id: ruff
args: ["--config", "pyproject.toml"]
Expand Down
4 changes: 3 additions & 1 deletion tests/test_package_gen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ def test_package_generation(
str(tmp_path),
f"project_slug={project_config['project_slug']}",
],
check=False,
shell=False, # noqa: S603
)

Expand All @@ -59,7 +60,7 @@ def test_package_generation(
assert (test_project_dir / f).exists()

# Need a .git directory in the project root
subprocess.run(["git", "init", test_project_dir]) # noqa: S603,S607
subprocess.run(["git", "init", test_project_dir], check=False) # noqa: S603,S607

# Check it's pip-installable
pipinstall = subprocess.run(
Expand All @@ -72,6 +73,7 @@ def test_package_generation(
test_project_dir,
],
capture_output=True,
check=False,
)
assert (
pipinstall.returncode == 0
Expand Down
2 changes: 1 addition & 1 deletion {{cookiecutter.project_slug}}/.pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
repos:
- repo: https://github.com/charliermarsh/ruff-pre-commit
rev: v0.0.284
rev: v0.0.291
hooks:
- id: ruff
- repo: https://github.com/Lucas-C/pre-commit-hooks
Expand Down