Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pydantic from pyproject.toml #173

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Remove pydantic from pyproject.toml #173

merged 2 commits into from
Oct 2, 2023

Conversation

dstansby
Copy link
Member

Since not all projects will use pydantic, I think it makes sense to remove these lines from pyproject.toml? In a new project I started I'm getting errors complaining that mypy can't find pydantic, and I don't want to install pydantic because I don't need it for the project.

@paddyroddy paddyroddy self-requested a review October 2, 2023 09:11
Copy link
Member

@paddyroddy paddyroddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. My thought was more that is useful, and not obvious how to make this template compatible with it. But we can remove it for now

@dstansby dstansby enabled auto-merge (squash) October 2, 2023 12:38
@dstansby dstansby merged commit 041aa6d into main Oct 2, 2023
6 checks passed
@dstansby dstansby deleted the dstansby-no-pydantic branch October 2, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants