DispersiveMultiLayer no longer uses MATLAB
#286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willGraham01
commented
May 10, 2023
samcunliffe
force-pushed
the
wgraham-181-less_matlab_more_hdf5
branch
from
e810276 to
f6789ab
Compare
Base automatically changed from
wgraham-181-less_matlab_more_hdf5
to
181-hdf5-io-pairdev
May 12, 2023 12:31
- xyz_vector struct of 3 vector<double>s introduced - DispersiveMultiLayer is now a struct with xyz_vector members - Preserve method for checking if the medium is dispersive - Temporarily disable unit tests for DispersiveMultiLayer class - HDF5Reader::read() can now assemble a DispersiveMultiLayer - HDF5Reader has a method for reading directly into a vector<T> - H5Dimension can be passed a H5::DataSet as well as a H5::DataSpace
* Move content of benchmark_scripts readme into doc/developers * Update CI attempt 1 * Actually use the right syntax * Force python version to prevent MacOS using python2.7 * Rename files to better match the data they produce * Aplease windows syntax * Remove pip cache due to known windows bug: actions/setup-python#436
samcunliffe
force-pushed
the
wgraham-DispersiveMultiLayer-no-matlab
branch
from
821f1ab to
d4d0cfd
Compare
samcunliffe
approved these changes
May 12, 2023
willGraham01
added a commit
that referenced
this pull request
May 19, 2023
* Rework DispersiveMultiLayer class into a struct. TDMS builds. - xyz_vector struct of 3 vector<double>s introduced - DispersiveMultiLayer is now a struct with xyz_vector members - Preserve method for checking if the medium is dispersive - Temporarily disable unit tests for DispersiveMultiLayer class - HDF5Reader::read() can now assemble a DispersiveMultiLayer - HDF5Reader has a method for reading directly into a vector<T> - H5Dimension can be passed a H5::DataSet as well as a H5::DataSpace * Update paths now we need HDF5 data as well as matlab data * TDMS builds and tests HDF5Reader::read_data_from_group (passes, no) * Fix seg-fault in read_dataset_from_group * Add DispersiveMultiLayer test * Update DispersiveMultiLayer tests to not be entangled with the MATLAB jargon * Update the CI so things actually work * Move content of benchmark_scripts readme into doc/developers * Update CI to produce unit test `.mat` and `.hdf5` data (#289) * Move content of benchmark_scripts readme into doc/developers * Update CI attempt 1 * Actually use the right syntax * Force python version to prevent MacOS using python2.7 * Rename files to better match the data they produce * Aplease windows syntax * Remove pip cache due to known windows bug: actions/setup-python#436 * Apply suggestions from code review
samcunliffe
pushed a commit
that referenced
this pull request
May 26, 2023
* Rework DispersiveMultiLayer class into a struct. TDMS builds. - xyz_vector struct of 3 vector<double>s introduced - DispersiveMultiLayer is now a struct with xyz_vector members - Preserve method for checking if the medium is dispersive - Temporarily disable unit tests for DispersiveMultiLayer class - HDF5Reader::read() can now assemble a DispersiveMultiLayer - HDF5Reader has a method for reading directly into a vector<T> - H5Dimension can be passed a H5::DataSet as well as a H5::DataSpace * Update paths now we need HDF5 data as well as matlab data * TDMS builds and tests HDF5Reader::read_data_from_group (passes, no) * Fix seg-fault in read_dataset_from_group * Add DispersiveMultiLayer test * Update DispersiveMultiLayer tests to not be entangled with the MATLAB jargon * Update the CI so things actually work * Move content of benchmark_scripts readme into doc/developers * Update CI to produce unit test `.mat` and `.hdf5` data (#289) * Move content of benchmark_scripts readme into doc/developers * Update CI attempt 1 * Actually use the right syntax * Force python version to prevent MacOS using python2.7 * Rename files to better match the data they produce * Aplease windows syntax * Remove pip cache due to known windows bug: actions/setup-python#436 * Apply suggestions from code review
willGraham01
added a commit
that referenced
this pull request
Jun 1, 2023
* Rework DispersiveMultiLayer class into a struct. TDMS builds. - xyz_vector struct of 3 vector<double>s introduced - DispersiveMultiLayer is now a struct with xyz_vector members - Preserve method for checking if the medium is dispersive - Temporarily disable unit tests for DispersiveMultiLayer class - HDF5Reader::read() can now assemble a DispersiveMultiLayer - HDF5Reader has a method for reading directly into a vector<T> - H5Dimension can be passed a H5::DataSet as well as a H5::DataSpace * Update paths now we need HDF5 data as well as matlab data * TDMS builds and tests HDF5Reader::read_data_from_group (passes, no) * Fix seg-fault in read_dataset_from_group * Add DispersiveMultiLayer test * Update DispersiveMultiLayer tests to not be entangled with the MATLAB jargon * Update the CI so things actually work * Move content of benchmark_scripts readme into doc/developers * Update CI to produce unit test `.mat` and `.hdf5` data (#289) * Move content of benchmark_scripts readme into doc/developers * Update CI attempt 1 * Actually use the right syntax * Force python version to prevent MacOS using python2.7 * Rename files to better match the data they produce * Aplease windows syntax * Remove pip cache due to known windows bug: actions/setup-python#436 * Apply suggestions from code review
willGraham01
added a commit
that referenced
this pull request
Jun 1, 2023
* `DispersiveMultiLayer` no longer uses MATLAB (#286) * Rework DispersiveMultiLayer class into a struct. TDMS builds. - xyz_vector struct of 3 vector<double>s introduced - DispersiveMultiLayer is now a struct with xyz_vector members - Preserve method for checking if the medium is dispersive - Temporarily disable unit tests for DispersiveMultiLayer class - HDF5Reader::read() can now assemble a DispersiveMultiLayer - HDF5Reader has a method for reading directly into a vector<T> - H5Dimension can be passed a H5::DataSet as well as a H5::DataSpace * Update paths now we need HDF5 data as well as matlab data * TDMS builds and tests HDF5Reader::read_data_from_group (passes, no) * Fix seg-fault in read_dataset_from_group * Add DispersiveMultiLayer test * Update DispersiveMultiLayer tests to not be entangled with the MATLAB jargon * Update the CI so things actually work * Move content of benchmark_scripts readme into doc/developers * Update CI to produce unit test `.mat` and `.hdf5` data (#289) * Move content of benchmark_scripts readme into doc/developers * Update CI attempt 1 * Actually use the right syntax * Force python version to prevent MacOS using python2.7 * Rename files to better match the data they produce * Aplease windows syntax * Remove pip cache due to known windows bug: actions/setup-python#436 * Apply suggestions from code review * Add line that was lost in rebase --------- Co-authored-by: willGraham01 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DispersiveMultiLayerclass from MATLAB - it is now astruct..matand.hdf5data #289)xyz_vectorstructwhich aims to replaceXYZVectorclass that depends on MATLABDispersiveMultiLayerin Classes to detach from MATLAB #285HDF5Reader::read_dataset_from_groupwhich can now robustly handle "normal"hdf5files (created via e.g.h5py) and.matfiles.create_hdf5_data.pyadded to repositoryThe
ci.yamlworkflow now runs thebenchmark/scripts which produce the unit test data, so there is no need to commit the binaries to the repository.Testing
HDF5Reader::read_dataset_from_groupDispersiveMultiLayeris_dispersive()methodHDF5Reader::read()method when passed a reference to aDispersiveMultiLayerobjectDocumentation
doc/developers.mdupdated to include details on how to add/edit/remove unit test data (see #289).