-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Matrix
to a strided vector
#307
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willGraham01
changed the base branch from
main
to
wgraham-EHVec-detach-from-matrix
May 19, 2023 14:42
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #307 +/- ##
===================================
- Coverage 27% 27% -0%
===================================
Files 75 77 +2
Lines 3699 3690 -9
===================================
- Hits 992 981 -11
- Misses 2707 2709 +2
☔ View full report in Codecov by Sentry. |
willGraham01
force-pushed
the
wgraham-Matrix_strided_vector
branch
from
May 19, 2023 16:49
cb2abde
to
6d4ff13
Compare
willGraham01
force-pushed
the
wgraham-EHVec-detach-from-matrix
branch
from
June 1, 2023 10:42
4e4946a
to
15b429b
Compare
willGraham01
force-pushed
the
wgraham-Matrix_strided_vector
branch
from
June 1, 2023 10:48
6d4ff13
to
1acf652
Compare
willGraham01
force-pushed
the
wgraham-EHVec-detach-from-matrix
branch
from
June 2, 2023 08:01
15b429b
to
4154d3d
Compare
willGraham01
force-pushed
the
wgraham-Matrix_strided_vector
branch
from
June 2, 2023 08:01
1acf652
to
2485c5a
Compare
willGraham01
force-pushed
the
wgraham-Matrix_strided_vector
branch
from
June 5, 2023 15:01
2485c5a
to
92a4c12
Compare
samcunliffe
approved these changes
Jun 5, 2023
Co-authored-by: Sam Cunliffe <[email protected]>
willGraham01
force-pushed
the
wgraham-Matrix_strided_vector
branch
from
June 5, 2023 15:42
6a4a112
to
4a3a1fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concerns #285:
Matrix
andCCoefficientMatrix
tasksPupil
from MATLABDescription
Converts the
Matrix
template class to a wrapper for strided vector storage.Derived class behaviour changes:
CCoefficientMatrix
is now just atypedef
forMatrix<double>
.Pupil
is astruct
that inherits fromMatrix<double>
.Vertices
&GratingStructure
arestruct
s that inherit fromMatrix<int>
.Although the only thing the derived "structs" now add is a unique way to read these classes via MATLAB. Once they have their
MATLAB
dependency removed, we can probably just typedef them all toMatrix<double/int>
.Testing
Tests are preserved for all existing classes.