Detach Vectors from MATLAB

[willGraham01]

Description

• Continues Classes to detach from MATLAB #285 | Resolves FieldComponentsVector and FrequencyExtractVector.

Detaches the FieldComponentsVector and FrequencyExtractVector classes from the Vector class, which depended on MATLAB.

• These two classes have been reduced to typedefs of std::vector.

The methods these classes had are now functions inside a (new) namespace tdms_vector_utils within utils.h.

• A lot of our existing classes have custom methods that perform identical tasks to those that these functions perform. Running a pass over our classes and refactoring those methods might give us a better idea of what should be a "class/struct" for us and what can just be typedefed.

Testing

• FieldComponentsVector and FrequencyExtractVector no longer have their own specific tests since they are now typedefs
• test_utils.h has additional tests for the new namespace and methods
• HDF5Reader::read() has another test for the new overload of read, for FrequencyExtractVectors.

The scripts that produce the input data have also been updated to include additional members that are needed for these unit tests.

Blocked by:

• Windows build does not support uint parallel for loop variables 😠

[codecov]

Codecov Report

Patch coverage: 52% and no project coverage change.

Comparison is base (c69f7f5) 25% compared to head (a3aab1c) 26%.

Additional details and impacted files

@@         Coverage Diff         @@
##           main   #328   +/-   ##
===================================
  Coverage    25%    26%           
===================================
  Files        80     81    +1     
  Lines      3660   3671   +11     
===================================
+ Hits        933    937    +4     
- Misses     2727   2734    +7     

Impacted Files	Coverage Δ
tdms/include/arrays.h	45% <ø> (+1%)	⬆️
tdms/include/hdf5_io/hdf5_dimension.h	0% <ø> (ø)
tdms/include/hdf5_io/hdf5_reader.h	0% <ø> (ø)
...s/include/simulation_manager/objects_from_infile.h	0% <ø> (ø)
tdms/include/utils.h	0% <0%> (ø)
tdms/include/vertex_phasors.h	0% <ø> (ø)
tdms/src/arrays.cpp	100% <ø> (+10%)	⬆️
...mulation_manager/execute_detector_subfunctions.cpp	0% <ø> (ø)
...simulation_manager/execute_phasor_subfunctions.cpp	0% <0%> (ø)
...dms/src/simulation_manager/objects_from_infile.cpp	0% <0%> (ø)
... and 6 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[samcunliffe]

Windows build does not support uint parallel for loop variables 😠

sigh. Might be able to isolate the Windows problem with a macro like #if OpenMP_VERSION < 3. Working over on my fork to see if we can get it working.

→ #339

[samcunliffe]

I like this very much.

(Except for the coverage weirdness that we discussed IRL. I do not like that.)

[samcunliffe]

🚀