-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New analysis functionality for the maternal and newborn health modules (intervention analysis) #1531
Open
joehcollins
wants to merge
31
commits into
master
Choose a base branch
from
jcollins/mnh_modules_update_intervention_analysis_dec24
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
New analysis functionality for the maternal and newborn health modules (intervention analysis) #1531
joehcollins
wants to merge
31
commits into
master
from
jcollins/mnh_modules_update_intervention_analysis_dec24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…red or not (can be used for analysis). updates to care_of_women_during_pregnancy.py to use this function (and some small fixes)
…his function (and some small fixes)
…y to use this function (and some small fixes)
… after change to parameter type to fix test
tbhallett
reviewed
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @joehcollins ---
I can't comment on the logic/epi, but the coding seems fine.
I had one question about a 'framework' xlsx file being touched, and wanted to know if this was intentional or not.
resources/ResourceFile_Improved_Healthsystem_And_Healthcare_Seeking.xlsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(this PR contains changes defined in #1477 which should be merged before this PR)
This PR updates the functionality used to conduct analysis with the maternal and newborn health modules. The main changes in this PR include:
A new function in
pregnancy_helper_functions.py
which is called whenever a MNH intervention should be delivered across the modules -check_int_deliverable
. Through this function the probability a given intervention is delivered can be set externally (overriding the probability of delivery generated through consumable availability and other relevant quality parameters). This function preserves previous functionality used in 'whole service' analysis conducted previouslyPrevious functions determining wether consumables were available/other quality parameters would permit intervention delivery (
return_cons_avail
andcheck_emonc_signal_function_will_run
) have been removedRedunant function logging met need of intervention delivery (
log_met_need
) removedModules have been updated so they call
check_int_deliverable
as required.Test files have been updated including new testing of
check_int_deliverable
These changes will be used to run the analysis for the upcoming MNH cohort model paper. Cohort model PR incoming.