-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NDNts-aux snapshot #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove other Adam Chen Injection XXX
as well. These comments do not explain the purpose of the code and I think is unnecessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now. Let me test this weekend and merge
Includes snapshot program parts 1,2,3 and some leftover debug code (when all testing is good will remove before merge)
Part 1 (yjsAdaptor): Check the state vector for the snapshot interval, and when the interval is up, publish and update the persistent storage on the blind fetch pointer of the latest snapshot.
Part 2 (syncAgent + namespace): An additional checker for the snapshot keyword for the existing syncAgent endpoint, and respond by checking persistent storage with the name as the key.
Lastly, a minor debug code is added to fetchBlob(), because I found that under heavier loads it is prone to lag and therefore cause problems to the synchronization process.
This pull request is meant to be a work-in-progress, as there are many debug codes to remove and unsafe calls to fix.
Attached are the slides and doc for documentation.
https://docs.google.com/presentation/d/15q8wTChtQtKzaAA1anvDJa1ZNr1DS1Kc67kW6XYghzM/edit?usp=sharing
https://docs.google.com/document/d/1s4pnJS4vSAP_EJD-P0XP6J5osoz8nNgEfLs-HOCDL6U/edit?usp=sharing