Resolve #111 Add test for PersistencePickle._simple_save #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarofpp
changed the title
RickFqt
reviewed
Nov 6, 2024
There was a problem hiding this comment.
I tried to run task shell and the task test related commands and got the following errors:
There was a problem hiding this comment.
I'm getting the same errors and after fixing the task shell one it also outputs "uids and gids must be in range 0-2147483647". (i'm on windows btw)
RickFqt
reviewed
Nov 6, 2024
| @@ -50,17 +50,23 @@ tasks: | |||
| shell: | |||
| desc: Runs the shell of a container. | |||
| cmds: | |||
| - ${CMD_DOCKER_RUN} -v ${ROOT}:/tmp -it ${PACKAGE_NAME} /bin/bash | |||
| - ${CMD_DOCKER_RUN} -u ${UID}:${GID -v ${ROOT}:/tmp -it ${PACKAGE_NAME} /bin/bash | |||
There was a problem hiding this comment.
Suggested change
| - ${CMD_DOCKER_RUN} -u ${UID}:${GID -v ${ROOT}:/tmp -it ${PACKAGE_NAME} /bin/bash | |
| - ${CMD_DOCKER_RUN} -u ${UID}:${GID} -v ${ROOT}:/tmp -it ${PACKAGE_NAME} /bin/bash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mambaorg/micromambaDocker image base from1.4.9to2.0.2.3.11to3.10to fix pysc2 incompatibility (TypeError: Random.shuffle() takes 2 positional arguments but 3 were givenonpysc2/lib/colors.py:121).PersistencePickle._simple_save.coverage.fail_underfrom100.0to90.0.Related: