Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EPP-57 Amend - SEC2 - Create a what is YOUR NAME on the licence page #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

EPP-57 Amend - SEC2 - Create a what is YOUR NAME on the licence page #9

wants to merge 2 commits into from

Conversation

PaolaDMadd-Pro
Copy link
Contributor

@PaolaDMadd-Pro PaolaDMadd-Pro commented Dec 20, 2024 •
edited
Loading

What?

Added what is your name page in amend path section 2

Why?

As per jira ticket EPP-57

How?

  • add fields in fields/index.js, fields.json, page.json, validation.json
  • add step in summary-data-sections.js
  • defined steps in index.js
  • add confirm.html,
  • update fields in summary-data-section,js
  • add fields for the confirm summary page
  • add initial page path for this section in apps/epp-common/index.js

Testing?

manual test

Screenshots (optional)

Anything Else? (optional)

Check list

  • I have reviewed my own pull request for linting issues (e.g. adding new lines)
  • I have written tests (if relevant)
  • I have created a JIRA number for my branch
  • I have created a JIRA number for my commit
  • I have followed the chris beams method for my commit https://cbea.ms/git-commit/
    here is an example commit
  • Ensure drone builds are green especially tests
  • I will squash the commits before merging

@PaolaDMadd-Pro
EPP-57 amend licence path
7f78864 
- add fields in fields/index.js, fields.json, page.json, validation.json
- add step in summary-data-sections.js
- defined steps in index.js
@PaolaDMadd-Pro PaolaDMadd-Pro marked this pull request as ready for review December 20, 2024 17:05
@PaolaDMadd-Pro
EPP-57 amendPath add some logic to render fields in summary page
a268b53 
- add confirm.html,
- update fields in summary-data-section,js
- add fields for the confirm summary page
- add initial page path for this section in apps/epp-common/index.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TemitopeAyokuHO TemitopeAyokuHO Awaiting requested review from TemitopeAyokuHO

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@PaolaDMadd-Pro