ROTM-80: Upgrade keycloak to v22 #246
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChisomOguibe11
force-pushed
the
ROTM-80
branch
from
1d4226d
to
0ff7e4d
Compare
| $kd -f kube/file-vault/file-vault-ingress.yml | ||
| $kd -f kube/configmaps/configmap.yml -f kube/app/service.yml | ||
| $kd -f kube/app/ingress-internal.yml -f kube/app/networkpolicy-internal.yml | ||
| $kd -f kube/redis -f kube/file-vault -f kube/app/deployment.yml | ||
| elif [[ ${KUBE_NAMESPACE} == ${PROD_ENV} ]]; then | ||
| export DISCOVERY_URL="https://sso.digital.homeoffice.gov.uk/auth/realms/rotm" |
There was a problem hiding this comment.
It's a good idea to do your dev/test like this
but for the final solution we are going to move this to right when ACP have created a prod version for keycloak v22? hof-config
There was a problem hiding this comment.
It's a good idea to do your dev/test like this but for the final solution we are going to move this to right when ACP have created a prod version for keycloak v22? hof-config
Yes there will be a new discovery URL for prod when acp upgrade keycloak in prod. I will add a comment in about this. Thanks
There was a problem hiding this comment.
can you amend your commits to follow the https://chris.beams.io/posts/git-commit/ format for commits?
can you also squash after it's merged
- file-vault's keycloak-proxy image was using a hardcoded discovery URL for all environments - value set to an env variable - set correctly according to the environment
ChisomOguibe11
force-pushed
the
ROTM-80
branch
from
0b139af
to
8626e17
Compare
comment to let others know that the prod discovery URL for keycloak will be changed after the upgrade in prod
ChisomOguibe11
force-pushed
the
ROTM-80
branch
from
65db66e
to
1a0a6f3
Compare
…workers" from keycloak-proxy upgraded rotm realm doesn't have a role called 'caseworkers'. Removing this line should allow files to upload to filevault
ChisomOguibe11
force-pushed
the
ROTM-80
branch
from
41d5812
to
59fd94b
Compare
…ontainers done to match filevault configuration in ACQ and IMA
ChisomOguibe11
force-pushed
the
ROTM-80
branch
from
33cd7a3
to
71713f5
Compare
…seworkers" to keycloak proxy commands change to match filevault configuration in ACQ and IMA
ChisomOguibe11
force-pushed
the
ROTM-80
branch
from
b73a0b3
to
62a4b6b
Compare
Following config used in IMA service to fix 502 error for file uploads
Following config used in IMA service to fix 502 error for file uploads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
Testing?
All tests passing in branch