Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOFF-925: Update filevault image to resolve vulnerabilities #275

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

HOFF-925: Update filevault image to resolve vulnerabilities #275

wants to merge 1 commit into from

Conversation

Rhodine-orleans-lindsay
Copy link
Contributor

@Rhodine-orleans-lindsay Rhodine-orleans-lindsay commented Nov 17, 2024 •
edited
Loading

What

Following filevault vulnerability fixes - HOFF-403, the filevault image has been updated in ROTM - HOFF-925

Why

  • To resolve vulnerabilities in the filevault microservice

How

  • Updated file-vault image in filevault deployment yam

Test

  • tested on branch

Screenshots(optional)

Anything else(optional)

  • updated snyk ignore list and yarn.lock

Check list

  • I have reviewed my own pull request for linting issues (e.g. adding new lines)
  • I have written tests (if relevant)
  • I have created a JIRA number for my branch
  • I have created a JIRA number for my commit
  • I have followed the chris beams method for my commit https://cbea.ms/git-commit/, here is an [example commit (https://github.com/UKHomeOfficeForms/hof/commit/810959f391187c7c4af6db262bcd143b50093a6e)
  • Ensure drone builds are green especially tests
  • I will squash the commits before merging

@Rhodine-orleans-lindsay Rhodine-orleans-lindsay force-pushed the HOFF-925-fv-vuln-fix branch 2 times, most recently from 1e92eed to a1cfbd7 Compare November 17, 2024 22:02
@Rhodine-orleans-lindsay Rhodine-orleans-lindsay marked this pull request as ready for review November 18, 2024 09:37
Adesh-Ramchurn
Adesh-Ramchurn reviewed Nov 18, 2024
View reviewed changes
.snyk Outdated Show resolved Hide resolved
@shamiluwais @Rhodine-orleans-lindsay
HOFF-925: update filevault image to fix vulnerabilities
01e762b 
- update filevault image in filevault-deployment.yml
- update package.json and yarn to fix vulnerabilities
- update .snyk list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adesh-Ramchurn Adesh-Ramchurn Adesh-Ramchurn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rhodine-orleans-lindsay @Adesh-Ramchurn @shamiluwais