Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[model cards] Keep evaluation order in training logs if there's multiple evaluators #2963

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

tomaarsen
Copy link
Collaborator

Hello!

Pull Request overview

  • Keep evaluation order in training logs if there's multiple evaluators
  • Rename "loss" to Validation Loss if there's only one loss

Details

I move away from the set-based implementation to a list-based one, so I can reuse the original ordering of the evaluators used in a SequentialEvaluator passed to the Trainer. This gives us e.g.:
image

Instead of e.g.

gooaq-1024-dev_cosine_map@100 gooaq-128-dev_cosine_map@100 gooaq-256-dev_cosine_map@100 gooaq-32-dev_cosine_map@100 gooaq-512-dev_cosine_map@100 gooaq-64-dev_cosine_map@100

Which was ordered based on the evaluation name (which isn't always useful, as can be seen here)

Also, we used to have

Epoch Step Training Loss loss

which just looked a bit odd, "loss" is now formatted as "Validation Loss" if there's only one loss.

  • Tom Aarsen

Also rename "loss" to Validation Loss
@tomaarsen tomaarsen merged commit a7cc68f into UKPLab:master Sep 30, 2024
11 checks passed
@tomaarsen tomaarsen deleted the fix/improve_model_cards branch September 30, 2024 14:49
tomaarsen added a commit to ArthurCamara/sentence-transformers that referenced this pull request Sep 30, 2024
…tiple evaluators (UKPLab#2963)

Also rename "loss" to Validation Loss
tomaarsen added a commit to alperctnkaya/sentence-transformers that referenced this pull request Oct 17, 2024
…tiple evaluators (UKPLab#2963)

Also rename "loss" to Validation Loss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant