Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps] Remove mandatory dependency of tokenizers #2998

Closed

Conversation

tomaarsen
Copy link
Collaborator

Resolves #2986

Hello!

Pull Request overview

  • Remove mandatory dependency of tokenizers

Details

But have a look at the discussion in #2986: if transformers can't be run without tokenizers, then this PR doesn't need to be merged. It can't be tested either, then.

cc @rasmi

  • Tom Aarsen

@tomaarsen
Copy link
Collaborator Author

Closing this PR, see reasoning here: #2986 (comment)

  • Tom Aarsen

@tomaarsen tomaarsen closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StaticEmbedding forces tokenizers dependency
1 participant