Update Gradle to v8.5 and JDK to v21 #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should download the version of Java specified in `build.gradle` if/as needed.
Version 21 is the most recent LTS as of this writing.
Adding the `foojay` plugin that downloads the correct version if it's not on the system generates a bunch of warnings when you run Gradle as it looks for the "right" version of Java. This adds a note telling the students that they can safely ignore these. I also used the `details` HTML tag to provide more information in a "hidden" block in case they want to learn more about what's going on here.
NicMcPhee
requested review from
kklamberty,
willster000,
stanislowskij and
ChenfeiP
NicMcPhee
added
enhancement
dependencies
This eliminates [a Gradle deprecation warning](https://docs.gradle.org/8.5/userguide/upgrading_version_8.html#test_framework_implementation_dependencies) that is introduced by upgrading to Gradle v8.5.
kklamberty
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
foojayresolver plugin, which should download the version of Java specified inbuild.gradleif that version isn't currently available on the system being usedfoojayplugin that downloads the correct version if it's not on the system generates a bunch of warnings when you run Gradle as it looks for the "right" version of Java. This adds a note telling the students that they can safely ignore these.Fixes #111
Fixes #113