Add test coverage #116
Merged
Add test coverage #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jacoco won't let us exclude just a method from the test coverage stats; we have to exclude whole classes. It then seemed to make sense to pull the `main()` method out into a new `Main` class, and then exclude that class from the code coverage stats.
This adds the relevant bits from the iteration template that tell Gradle to compute and check the Jacoco test coverage stats. We exclude `Main.class` since it's just the really simple `main()` method.
NicMcPhee
requested review from
kklamberty,
willster000,
stanislowskij and
ChenfeiP
NicMcPhee
changed the title
NicMcPhee
changed the title
This got a bit away from me. My real goal was just to make sure that the documentation was consistent with the changes I made to add test coverage, but I ended up making a number of other changes as well. Sorry.
The old way was deprecated, but this makes the last deprecation warning go away.
kklamberty
approved these changes
Jan 12, 2024
|
Good catch! I had "Merge when ready" turned on, so it already committed, but I'm happy about the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the relevant bits from the iteration template that tell Gradle to compute and check the Jacoco test coverage stats.
Jacoco won't let us exclude just a method from the test coverage stats; we have to exclude whole classes. It then seemed to make sense to pull the
main()method out into a newMainclass, and then exclude that class from the code coverage stats.We then exclude
Main.classsince it's just the really simplemain()method.I updated the Markdown files to make sure that the they were up-to-date with the refactoring I did here. While I was there I got excited and made several other edits that really had nothing to do with this PR – sorry. 😢 If anyone wants me to separate them out, just say so.
Closes #114