121 fix tenses and phrasing #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As @kklamberty pointed out, using the past tense for our names was weird, and use "preferred" in "My preferred pronouns" seems weaker that just stating "My pronouns are…". This fixes those issues.
The phrase "preferred pronouns" is too weak, so (at @kklamberty's suggestion) changed it to just "Your pronouns". I'm not sure if we still want the link there – is that useful or just unnecessary now?
NicMcPhee
commented
Jan 12, 2024
|
kklamberty
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kklamberty pointed out that we were using past tense in a weird way in our example, and we were using the phrase like "My preferred pronouns", which is weak and we should just say "My pronouns".
Fixes #121