Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Play with Azure B2C authentication. #290

Open
wants to merge 29 commits into
base: develop
Choose a base branch
from

Conversation

cafuego
Copy link
Contributor

@cafuego cafuego commented Jun 19, 2023

So step 1 is to add and enable the module.

Refs: OPS-7872

@github-actions
Copy link

github-actions bot commented Jun 19, 2023

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions PHP 8.2.20 (cli) (built: Jun 6 2024 17:46:29) (NTS) Copyright (c) The PHP Group Zend Engine v4.2.20, Copyright (c) Zend Technologies with Zend OPcache v8.2.20, Copyright (c), by Zend Technologies with Xdebug v3.3.2, Copyright (c) 2002-2024, by Derick Rethans Composer version 2.7.7 2024-06-10 22:11:12
Drupal Logs

Pusher: @cafuego, Action: pull_request, Workflow: Run tests

Copy link
Contributor

@rupl rupl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't properly test this because of the inherent domain restriction, but it looks decent after having scanned the diff.

@cafuego
Copy link
Contributor Author

cafuego commented Feb 26, 2024

Uh, yes. it worked fine whilst installed :-)

@rupl
Copy link
Contributor

rupl commented Feb 27, 2024

lol ok I didn't look at the date. as you were 😆

@cafuego cafuego requested a review from attiks March 1, 2024 01:11
@cafuego
Copy link
Contributor Author

cafuego commented Mar 1, 2024

This is currently deployed to CD feature.

@lazysoundsystem
Copy link
Contributor

How is this coming along? It's now giving us a fail for the feature updates job https://jenkins.aws.ahconu.org/view/Updates/job/ds-commondesign-feature-updates/1338/ - but updating the branch from develop is proving pretty tricky.

Copy link

Coverage Report

Totals Coverage

@cafuego
Copy link
Contributor Author

cafuego commented Jun 26, 2024

I get the impression you should be in bed and asleep as opposed to trying to resolve merge conflicts.

@lazysoundsystem
Copy link
Contributor

Thanks for this - I got quite far on the merge but didn't want to break anything in the process.

Deploying now to the feature instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants