-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Play with Azure B2C authentication. #290
base: develop
Are you sure you want to change the base?
Conversation
Build outputComposer Validate
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't properly test this because of the inherent domain restriction, but it looks decent after having scanned the diff.
Uh, yes. it worked fine whilst installed :-) |
lol ok I didn't look at the date. as you were 😆 |
This is currently deployed to CD feature. |
How is this coming along? It's now giving us a fail for the feature updates job https://jenkins.aws.ahconu.org/view/Updates/job/ds-commondesign-feature-updates/1338/ - but updating the branch from develop is proving pretty tricky. |
I get the impression you should be in bed and asleep as opposed to trying to resolve merge conflicts. |
Thanks for this - I got quite far on the merge but didn't want to break anything in the process. Deploying now to the feature instance. |
So step 1 is to add and enable the module.
Refs: OPS-7872