Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPC-9354: Add visibilityPreferences to planVersion model #137

Merged
merged 2 commits into from
Mar 6, 2024
Merged

HPC-9354: Add visibilityPreferences to planVersion model #137

merged 2 commits into from
Mar 6, 2024

Conversation

enxtur
Copy link
Contributor

@enxtur enxtur commented Jan 24, 2024 •
edited by Pl217
Loading

Added disaggregation visibility fields to planVersion model.

@enxtur enxtur self-assigned this Jan 24, 2024
@enxtur enxtur requested a review from a team as a code owner January 24, 2024 10:45
@enxtur enxtur added the ready for review All comments have been addressed, and the Pull Request is ready for review label Jan 30, 2024
@enxtur enxtur assigned Pl217 and unassigned enxtur Jan 30, 2024
Pl217
Pl217 requested changes Feb 21, 2024
View reviewed changes
src/auth/permissions.ts Outdated Show resolved Hide resolved
src/db/models/planVersion.ts Outdated Show resolved Hide resolved
@Pl217 Pl217 assigned enxtur and unassigned Pl217 Feb 21, 2024
@Pl217 Pl217 added needs major changes There are review or issue comments to address that will result in big changes and removed ready for review All comments have been addressed, and the Pull Request is ready for review labels Feb 21, 2024
@enxtur enxtur force-pushed the HPC-9354 branch 2 times, most recently from 2031f15 to a7dd655 Compare March 1, 2024 12:22
@enxtur enxtur assigned Pl217 and unassigned enxtur Mar 1, 2024
@enxtur enxtur added ready for review All comments have been addressed, and the Pull Request is ready for review and removed needs major changes There are review or issue comments to address that will result in big changes labels Mar 1, 2024
@enxtur enxtur requested a review from Pl217 March 1, 2024 14:06
@Pl217 Pl217 added ready for merge Review and testing is complete. It is ready for merging as soon as CI has finished. and removed ready for review All comments have been addressed, and the Pull Request is ready for review labels Mar 6, 2024
@Pl217 Pl217 changed the title HPC-9354: Add disaggregation visibility permissions HPC-9354: Add visibilityPreferences to planVersion model Mar 6, 2024
@Pl217 Pl217 merged commit abaa2b4 into develop Mar 6, 2024
2 checks passed
@Pl217 Pl217 deleted the HPC-9354 branch March 6, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pl217 Pl217 Pl217 approved these changes

Assignees

@Pl217 Pl217

Labels
ready for merge Review and testing is complete. It is ready for merging as soon as CI has finished.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enxtur @Pl217