Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPS-10828] Add Entra ID login/registration #959

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

orakili
Copy link
Collaborator

@orakili orakili commented Dec 5, 2024

Refs: OPS-10828, OPS-10896

This adds the https://github.com/UN-OCHA/ocha_entraid module and disable the reliefweb_entraid module (to be removed in another PR).

Note: permissions to access the login and registration forms are not yet set since we are still waiting for some approval (see OPS-10896) but that can be added via the UI and later saved to code (see #960)

@orakili orakili requested a review from cafuego December 5, 2024 02:23
cafuego
cafuego previously approved these changes Dec 5, 2024
Copy link
Contributor

@cafuego cafuego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we're not worried about the reliefweb_entraid route changes, given the module will go away :-)

Copy link

github-actions bot commented Dec 5, 2024

Coverage Report

Totals Coverage
Statements: 9.37% ( 1150 / 12273 )
Methods: 12.98% ( 91 / 701 )
Lines: 9.15% ( 1059 / 11572 )

Copy link

github-actions bot commented Dec 5, 2024

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions Docker version 26.1.3, build b72abbb PHP 8.3.14 (cli) (built: Nov 20 2024 19:56:36) (NTS) Copyright (c) The PHP Group Zend Engine v4.3.14, Copyright (c) Zend Technologies with Zend OPcache v8.3.14, Copyright (c), by Zend Technologies with Xdebug v3.3.2, Copyright (c) 2002-2024, by Derick Rethans Composer version 2.8.3 2024-11-17 13:13:04
Drupal Logs
PHP Logs

Pusher: @orakili, Action: pull_request, Workflow: Run tests

Copy link
Contributor

@cafuego cafuego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I thought as much. Still approved :-)

@orakili orakili merged commit 6e04c13 into develop Dec 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants