Add learning outcomes to Sparse Linear Algebra #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jcohen02 - who could possibly be a reviewer for this PR? Any suggestions? |
|
Thanks for this PR @SaranjeetKaur, maybe @martinjrobins or @fcooper8472 could review and merge if all ok? |
SaranjeetKaur
changed the title
martinjrobins
requested changes
Nov 15, 2024
There was a problem hiding this comment.
Thanks @SaranjeetKaur, I've made a few changes to these, see what you think
scientific_computing/sparse_linear_algebra/03-finite-difference.md
Outdated
Show resolved
Hide resolved
scientific_computing/sparse_linear_algebra/06-jacobi-relaxation-methods.md
Outdated
Show resolved
Hide resolved
scientific_computing/sparse_linear_algebra/07-conjugate-gradient-method.md
Outdated
Show resolved
Hide resolved
scientific_computing/sparse_linear_algebra/07-conjugate-gradient-method.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Martin Robinson <[email protected]>
|
Thanks @martinjrobins! I have applied the suggestions from your review. |
martinjrobins
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #161
This PR adds learning outcomes to the chapters in Sparse Linear Algebra which is a part of Scientific Computing.