fix: correctly change topology when no previous model (#1909)

Thanks to Susana Aguilar
UPC · Feb 7, 2023 · 8fee945 · 8fee945
1 parent 24efd81
commit 8fee945
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/Ravada/Domain/KVM.pm b/lib/Ravada/Domain/KVM.pm
@@ -3348,7 +3348,11 @@ sub _change_xml($xml, $name, $data) {
             if ($node->textContent ne $text) {
                 my ($n_text) = $node->findnodes("text()");
                 eval {
-                    $n_text->setData($text);
+                    if (!$n_text) {
+                        $node->appendText($text);
+                    } else {
+                        $n_text->setData($text);
+                    }
                 };
                 confess $@."\n".Dumper($node->toString,$name,$data)
                 if $@;

diff --git a/t/request/30_hardware.t b/t/request/30_hardware.t
@@ -1283,6 +1283,9 @@ sub _test_cpu_topology_old_cpu($domain) {
     $cpu->removeAttribute('match');
 
     my ($model) = $cpu->findnodes('model');
+    $cpu->removeChild($model);
+
+    $domain->reload_config($doc);
 
     my $model_exp = 'kvm64';