make sure to always add the template even if unused

USACE · Nov 13, 2024 · 11d32cc · 11d32cc
1 parent 836d2ad
commit 11d32cc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/cwms-data-api/src/main/java/cwms/cda/data/dao/RatingTemplateDao.java b/cwms-data-api/src/main/java/cwms/cda/data/dao/RatingTemplateDao.java
@@ -159,9 +159,9 @@ static void addTemplate(Record rec, Map<RatingTemplate, List<String>> map) {
         try {
             RatingTemplate template = buildRatingTemplate(rec);
             String specID = rec.get(AV_RATING_SPEC.AV_RATING_SPEC.RATING_ID);
+            List<String> ratingSpecs = map.computeIfAbsent(template, k -> new ArrayList<>());
             if (specID != null) {
-                map.computeIfAbsent(template, k -> new ArrayList<>())
-                    .add(specID);
+                ratingSpecs.add(specID);
             }
         } catch(RuntimeException ex) {
             logger.log(Level.WARNING, ex, () ->

diff --git a/cwms-data-api/src/test/java/cwms/cda/api/RatingTemplateControllerTestIT.java b/cwms-data-api/src/test/java/cwms/cda/api/RatingTemplateControllerTestIT.java
@@ -37,16 +37,16 @@
 import javax.servlet.http.HttpServletResponse;
 import mil.army.usace.hec.cwms.rating.io.xml.RatingSpecXmlFactory;
 
-import org.junit.jupiter.api.RepeatedTest;
 import org.junit.jupiter.api.Tag;
 
 import cwms.cda.data.dao.JooqDao;
 import cwms.cda.formatters.Formats;
+import org.junit.jupiter.api.Test;
 
 @Tag("integration")
 class RatingTemplateControllerTestIT extends DataApiTestIT {
 
-    @RepeatedTest(value = 30)
+    @Test
     void test_create_read_delete() throws Exception {
         String locationId = "RatingSpecTest";
         String officeId = "SPK";