Changed new parameters to non-required

USACE · Nov 18, 2024 · c153805 · c153805
1 parent bf541ae
commit c153805
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/cwms-data-api/src/main/java/cwms/cda/api/LocationGroupController.java b/cwms-data-api/src/main/java/cwms/cda/api/LocationGroupController.java
@@ -172,8 +172,11 @@ public void getOne(@NotNull Context ctx, @NotNull String groupId) {
             LocationGroupDao cdm = new LocationGroupDao(dsl);
             String office = requiredParam(ctx, OFFICE);
             String categoryId = requiredParam(ctx, CATEGORY_ID);
-            String groupOfficeId = requiredParam(ctx, GROUP_OFFICE_ID);
-            String categoryOfficeId = requiredParam(ctx, CATEGORY_OFFICE_ID);
+
+            // Not marked as required to maintain backwards compatibility with existing clients
+            String groupOfficeId = ctx.queryParam(GROUP_OFFICE_ID);
+            String categoryOfficeId = ctx.queryParam(CATEGORY_OFFICE_ID);
+
             String formatHeader = ctx.header(Header.ACCEPT);
             String result;
             ContentType contentType;

diff --git a/cwms-data-api/src/main/java/cwms/cda/api/TimeSeriesGroupController.java b/cwms-data-api/src/main/java/cwms/cda/api/TimeSeriesGroupController.java
@@ -188,8 +188,10 @@ public void getOne(@NotNull Context ctx, @NotNull String groupId) {
             TimeSeriesGroupDao dao = new TimeSeriesGroupDao(dsl);
             String office = ctx.queryParam(OFFICE);
             String categoryId = ctx.queryParam(CATEGORY_ID);
-            String groupOffice = requiredParam(ctx, GROUP_OFFICE_ID);
-            String categoryOffice = requiredParam(ctx, CATEGORY_OFFICE_ID);
+
+            // Not marked as required to maintain backwards compatibility with existing clients
+            String groupOffice = ctx.queryParam(GROUP_OFFICE_ID);
+            String categoryOffice = ctx.queryParam(CATEGORY_OFFICE_ID);
 
             String formatHeader = ctx.header(Header.ACCEPT);
             ContentType contentType = Formats.parseHeader(formatHeader, TimeSeriesGroup.class);