[WIP] Feature/async sse. Do not merge. #518
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeNeilson
reviewed
Jan 29, 2024
| if (typeof (EventSource) !== "undefined") { | ||
| var clobId = "/TIME SERIES TEXT/6261044"; | ||
| console.log("clobId: " + clobId + " encodeURIComponent: " + encodeURIComponent(clobId) + " encodeURI: " + encodeURI(clobId)); | ||
| var source = new EventSource("http://localhost:7000/cwms-data/sse/clob" |
There was a problem hiding this comment.
I think I understand part of why it's not as common. Entirely new data type, doesn't seem too difficult to use but it's clear a fallback is required anyways so we might as well do the various long-polling methods.
There was a problem hiding this comment.
Though we should keep it in mind for things like CWMS Server/Client communication and say, team forecasting. And I can see some value over at OpenDCS/LRGS. But really just in a constrained context where you know it can work.
…ot deploying into tomcat.
…etting picked up.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.