Feature/ForecastControllers #591
Conversation
cwms-data-api/src/main/java/cwms/cda/api/ForecastTimeseriesController.java
Outdated
Show resolved
Hide resolved
|
Some questions regarding forecast spec. For the getAll request should the officeId parameter have a filter or should it be included as a single officeId? Furthermore, is the officeId a required parameter? Would a source entity filter be useful? |
…ions for ForecastSpecController.java
…anceController.java
…r.java. Added not supported bodies to functions.
|
For getAll probably not required. but certainly useful for filtering. |
| @@ -121,15 +121,22 @@ public final class Controllers { | |||
| public static final String TIMESERIES = "timeseries"; | |||
| public static final String LOCATIONS = "locations"; | |||
|
|
|||
| public static final String SPEC_ID = "spec-id"; | |||
| public static final String LOCATION = "location"; | |||
There was a problem hiding this comment.
I'd go with "location-id", surprised there isn't an example already
There was a problem hiding this comment.
you can remove this one?
cwms-data-api/src/main/java/cwms/cda/api/ForecastInstanceController.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/main/java/cwms/cda/api/ForecastInstanceController.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/main/java/cwms/cda/api/ForecastInstanceController.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/main/java/cwms/cda/api/ForecastTimeseriesController.java
Show resolved
Hide resolved
| tags = TAG | ||
| ) | ||
| @Override | ||
| public void create(@NotNull Context ctx) { |
There was a problem hiding this comment.
I'm re-thinking how this create would work.
Workflow:
client creates a spec, providing a list of time series ids
client creates an instance for a spec when going to run a forecast
client posts the results for the list of time series associated with the spec. -> isn't this just the time series controller? the spec is already associated with the time series identifier and the instance is already associated with the values given the forecast date and the time series id. What extra logic is needed by CDA to tie the time series storage to the instance?
Similarly for the delete, any interactions would be in the existing timeseries controller.
cwms-data-api/src/main/java/cwms/cda/api/ForecastSpecController.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/main/java/cwms/cda/api/ForecastSpecController.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
This file shouldn't have needed to change
Controllers for forecast data