-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Index Page to Groundwork/React #658
Draft
krowvin
wants to merge
16
commits into
develop
Choose a base branch
from
index-page-to-groundwork-react
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ind globally disabling UL tags to solve.
…t-router-dom instead of redux-bundler-hook.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Landing Page to Groundwork + React using Vite.js
This PR is for issue #572
NOTE THIS PR SHOULD NOT BE APPROVED UNTIL CONFIRMED WORKING ON VARIOUS URL PATHS
See Route Issues below - Looking for assistance and suggestions on this!
Major Changes:
pages
via react-router-dom (see below)From the
cwms-data-api\src\main\webapp-src
path runnpm run
to see the available commands or opencwms-data-api/src/main/webapp-src/package.json
and look atscripts
.npm run build
dist
to thewebapps
directory (there is a script that will do this for windows in thepackage.json
)Things of Note:
Redux-Bundler
as the client-side routing framework. However, in testing I attempted to use both this andreact-router-dom
to override the dynamic client-side routing.cwms-data-api/src/main/webapp/WEB-INF/web.xml
had to be edited to handle404 Not Found
errors and pass them back to the client to handle the client-side routing. There may be a better way to handle this.Route Issues
I was able to get this working by hard coding the
base
path in vite.js and incwms-data-api\src\main\webapp-src\src\bundles\route-bundle.js
However, we need this to be dynamic for the district T7s.
I took two attempts at this:
redux-bundler
-> Initial commitsreact-router-dom
-> Current HEAD stateIf you would like to jump to the commit where I had
redux-bundler
setup the commit hash is 7c572b4635d13bbcbd907bab3a47a9b12732c2ce