Feature/cto 104 reservoir project #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeNeilson
reviewed
Jun 10, 2024
| private final Calendar UTC_CALENDAR = Calendar.getInstance(TimeZone.getTimeZone("UTC")); | ||
|
|
||
| public static final String SELECT_PART = "select project.office_id,\n" | ||
| + " project.location_id as project_id,\n" |
There was a problem hiding this comment.
For want of Java 17 that allows the python style """ strings.
There was a problem hiding this comment.
It will be cleaner when I move the query into a resource file
| builder.withPumpBackLocation(new Location.Builder(r.getOFFICE_ID(), r.getPUMP_BACK_LOCATION_ID()) | ||
| .withActive(null) | ||
| .build() | ||
| ); // Can we assume same office? |
There was a problem hiding this comment.
Hmm, that's a good question. And one for the districts, but I suspect it's cleaner here later if we just don't.
The query above does include the given office_id for each and should probably be used.
There was a problem hiding this comment.
Just removed the method that used the view with the missing office-ids. We'll use the table join for now.
There was a problem hiding this comment.
A reasonable substitute.
MikeNeilson
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.