Implemented LookupType Controller. Added 'update' method to LookupType DAO #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeNeilson
reviewed
Jun 7, 2024
| .findFirst() | ||
| .orElse(null); | ||
| if (lookupType != null) { | ||
| dao.deleteLookupType(category, prefix, lookupType); |
There was a problem hiding this comment.
Does this call not fail in a manageable way and that's why you're doing the lookup first?
There was a problem hiding this comment.
Refactored the retrieval into the DAO's delete method
MikeNeilson
previously approved these changes
Jun 7, 2024
adamkorynta
reviewed
Jun 7, 2024
adamkorynta
reviewed
Jun 7, 2024
adamkorynta
previously approved these changes
Jun 7, 2024
…e DAO that checks for existing lookup type.
…ete to take in office id and display value rather than LookupType object.
rma-bryson
force-pushed
the
feature/lookup_type
branch
from
20c30c8 to
7076eec
Compare
adamkorynta
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.