DTO and serialization for Time Zones #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we get a unit test of just the TimeZone DTO serialization by itself? Include a json or xml example file. |
Removing unused import from time zone
|
I'd like to see a resource file with an example of the serialized format. |
|
oh, actually I should also get a test for the List in there too, since that's what we're serializing with getAll. I totally meant to do that. |
Added TimeZones class so we can deserialize to and from a list object like LocationLevels.
MikeNeilson
approved these changes
Jun 17, 2024
rma-rripken
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding DTO and serialization process for time zones, so we can use the newer java json/xml serialization/deserialization
Fixes #499