Lock and LockRevokerRights classes. #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamkorynta
reviewed
Jun 18, 2024
cwms-data-api/src/main/java/cwms/cda/data/dto/project/Lock.java
Outdated
Show resolved
Hide resolved
adamkorynta
reviewed
Jun 18, 2024
adamkorynta
reviewed
Jun 18, 2024
cwms-data-api/src/main/java/cwms/cda/data/dao/project/ProjectLockDao.java
Show resolved
Hide resolved
|
@adamkorynta @MikeNeilson What other changes do you need to see in here? The Dao issues will get re-litigated when Controller/Handler IT are further along. |
|
I'll let Peter review the JSON/DTO, I don't have anymore comments on the rest. |
adamkorynta
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm including the dao here so that everything compiles. Additional dao tests will be included in followup pr