Added global fetchSize variables to DAOs #877
Conversation
| @@ -69,6 +68,8 @@ | |||
| public abstract class JooqDao<T> extends Dao<T> { | |||
| protected static final int ORACLE_CURSOR_TYPE = -10; | |||
| private static final FluentLogger logger = FluentLogger.forEnclosingClass(); | |||
| public static final int FETCH_SIZE = 1000; | |||
There was a problem hiding this comment.
I feel like this should be DEFAULT_FETCH_SIZE and DEFAULT_SMALL_FETCH_SIZE or the like.
Over time we will likely find that we need to fine tune this for different queries though this is a solid baseline, especially over the apparent default of 10.
There was a problem hiding this comment.
If wanting to tune this, I recommend that this variable be changed to public static getDefaultFetchSize method that supports a System property override if System property changes are easily done.
There was a problem hiding this comment.
I doubt we'd want to do a global override of the fetch size. If it's tweaked, it's going to be per query based on that queries specific need.
| @@ -69,6 +68,8 @@ | |||
| public abstract class JooqDao<T> extends Dao<T> { | |||
| protected static final int ORACLE_CURSOR_TYPE = -10; | |||
| private static final FluentLogger logger = FluentLogger.forEnclosingClass(); | |||
| public static final int FETCH_SIZE = 1000; | |||
| public static final int HALF_FETCH_SIZE = FETCH_SIZE / 2; | |||
There was a problem hiding this comment.
I wouldnt code this as a half fetch size but instead as Mike called out above. SMALL and set it to 500. I think the relationship between the two values in the code is arbitrary.
There was a problem hiding this comment.
I updated the naming and set the small fetch size to 500
|
The default size can get set via properties on the connection pool. See |
|
I'd have to check in more detail, but there are two pool classes in Tomcat by default and I believe we use the other one. May have a similar setting though. |
Added global fetchSize variables to JooqDao and appropriate DAOs