Add Lock Support #883
Merged
Add Lock Support #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently missing fields for the Lock DTO that wil be resolved once https://jira.hecdev.net/browse/CTO-147 is completed
adamkorynta
requested changes
Oct 7, 2024
cwms-data-api/src/main/java/cwms/cda/data/dto/location/kind/Lock.java
Outdated
Show resolved
Hide resolved
adamkorynta
reviewed
Oct 17, 2024
adamkorynta
reviewed
Oct 29, 2024
| } | ||
|
|
||
| public String getLevelURI() { | ||
| return levelURI; |
There was a problem hiding this comment.
This contains a good idea for how to do links: https://cloud.google.com/blog/products/application-development/api-design-why-you-should-use-links-not-keys-to-represent-relationships-in-apis
Probably worth opening up a GitHub Discussion on the topic.
There was a problem hiding this comment.
Created a discussion post here: #936
zack-rma
commented
Nov 7, 2024
cwms-data-api/src/main/java/cwms/cda/data/dao/location/kind/LockDao.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/main/java/cwms/cda/data/dao/location/kind/LockDao.java
Outdated
Show resolved
Hide resolved
rma-bryson
requested changes
Nov 13, 2024
cwms-data-api/src/main/java/cwms/cda/api/location/kind/LockController.java
Show resolved
Hide resolved
cwms-data-api/src/main/java/cwms/cda/data/dto/location/kind/LockLocationLevelRef.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/test/java/cwms/cda/data/dao/location/kind/LockDaoTest.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/main/java/cwms/cda/data/dao/location/kind/LockDao.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/main/java/cwms/cda/data/dao/location/kind/LockDao.java
Outdated
Show resolved
Hide resolved
rma-bryson
reviewed
Nov 14, 2024
cwms-data-api/src/main/java/cwms/cda/api/location/kind/LockController.java
Outdated
Show resolved
Hide resolved
rma-bryson
reviewed
Nov 14, 2024
cwms-data-api/src/main/java/cwms/cda/data/dao/location/kind/LockDao.java
Outdated
Show resolved
Hide resolved
rma-bryson
requested changes
Nov 18, 2024
cwms-data-api/src/main/java/cwms/cda/data/dao/location/kind/LockDao.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/main/java/cwms/cda/data/dao/location/kind/LockDao.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/main/java/cwms/cda/data/dao/location/kind/LockDao.java
Outdated
Show resolved
Hide resolved
rma-bryson
approved these changes
Nov 19, 2024
adamkorynta
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding reservoir lock support