CWDB-225 - Implemented Measurement Controller #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zack-rma
reviewed
Oct 11, 2024
cwms-data-api/src/main/java/cwms/cda/api/MeasurementController.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/main/java/cwms/cda/api/MeasurementController.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/main/java/cwms/cda/api/MeasurementController.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/main/java/cwms/cda/api/MeasurementController.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/main/java/cwms/cda/api/MeasurementController.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/main/java/cwms/cda/api/MeasurementPatchController.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/test/java/cwms/cda/api/MeasurementControllerTestIT.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/test/java/cwms/cda/api/MeasurementControllerTestIT.java
Show resolved
Hide resolved
cwms-data-api/src/test/java/cwms/cda/api/MeasurementControllerTestIT.java
Outdated
Show resolved
Hide resolved
rma-bryson
force-pushed
the
feature/CWDB-225_Measurement_controller
branch
from
cf63abe to
502182a
Compare
zack-rma
reviewed
Oct 14, 2024
cwms-data-api/src/test/java/cwms/cda/api/MeasurementControllerTestIT.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/test/java/cwms/cda/api/MeasurementControllerTestIT.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/test/java/cwms/cda/api/MeasurementControllerTestIT.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/test/java/cwms/cda/api/MeasurementControllerTestIT.java
Outdated
Show resolved
Hide resolved
…easurements to cleanup routine in IT. Code format refactors.
rma-bryson
force-pushed
the
feature/CWDB-225_Measurement_controller
branch
from
f88aea1 to
a84e771
Compare
adamkorynta
requested changes
Oct 16, 2024
…ements for bulk update
|
@MikeNeilson - With Measurements we wanted to support a bulk store, and there is no rename, so update is really just a check-for-existing and then store... The test db doesn't have display units for the office (SPK) needed for bulk retrieving existing measurements efficiently (there is jooq code in the MeasurementDao that retrieves in bulk from the meas view, with the given meas numbers), which causes the tests to fail, without configuring the at_display_units table manually for SPK . If configured, the existing check does work as expected. EDIT: after further discussion we decided its best to just not support an update at all for measurements, as it doesn't make much sense. No PATCH, just POST. |
adamkorynta
requested changes
Oct 17, 2024
cwms-data-api/src/main/java/cwms/cda/api/MeasurementController.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/main/java/cwms/cda/api/MeasurementController.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/main/java/cwms/cda/api/MeasurementController.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/main/java/cwms/cda/api/MeasurementController.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/main/java/cwms/cda/api/MeasurementController.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/main/java/cwms/cda/api/MeasurementController.java
Outdated
Show resolved
Hide resolved
…ed via a single-element-array. Updated to support all optional query parameters for retrieval.
adamkorynta
reviewed
Oct 17, 2024
adamkorynta
requested changes
Oct 17, 2024
cwms-data-api/src/main/java/cwms/cda/api/MeasurementController.java
Outdated
Show resolved
Hide resolved
…s. Made descriptions of date/timezones consistent.
…of null begin/end.
adamkorynta
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.