Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 650 - Updated LocationLevel getOne to handle custom units #908

Merged
merged 5 commits into from
Dec 9, 2024

Conversation

zack-rma
Copy link
Collaborator

@zack-rma zack-rma commented Oct 10, 2024

Fixes #650 - Updated LocationLevel getOne to handle custom units and unit systems

@zack-rma
Copy link
Collaborator Author

zack-rma commented Oct 10, 2024

I also discovered that the effective date query parameter for getOne is used as the end date in the PL/SQL call. Effectively, any date provided that is after the effective date of the target locationLevel will work to find that locationLevel. This also results in the returned effective date being set to the provided value, not the DB value.

Not sure about the impact of this, maybe it should get its own issue? @MikeNeilson

MikeNeilson
MikeNeilson previously approved these changes Oct 11, 2024
@MikeNeilson
Copy link
Contributor

I also discovered that the effective date query parameter for getOne is used as the end date in the PL/SQL call. Effectively, any date provided that is after the effective date of the target locationLevel will work to find that locationLevel. This also results in the returned effective date being set to the provided value, not the DB value.

Not sure about the impact of this, maybe it should get its own issue? @MikeNeilson

Sorry, I've re-read this several times and I'm still having difficulty following the issue; I mean it seems like an issue but it's not mapping in my head. Any way to make a simple diagram, flow chart, just plain example data where the issue would be more obvious to myself and others.?

@adamkorynta
Copy link
Collaborator

If I'm following correctly: lets say I pass in today's date, it'll give me back the loc level value from the last effective date (let's say last year), but the DTO returns today's date as the effective date.

@MikeNeilson
Copy link
Contributor

Ah. I see, yeah the correct effective date should be what's in the DTO.

@zack-rma zack-rma force-pushed the location_level_issue_650 branch from 1fd8b80 to 3e19a62 Compare October 23, 2024 16:55
@zack-rma
Copy link
Collaborator Author

Rebased to fix build errors.

@zack-rma
Copy link
Collaborator Author

zack-rma commented Nov 4, 2024

Rebased to fix build issue

@zack-rma
Copy link
Collaborator Author

zack-rma commented Dec 7, 2024

Build errors appear to be unrelated to these changes

@zack-rma zack-rma requested a review from adamkorynta December 9, 2024 17:09
@adamkorynta adamkorynta merged commit f3f6c73 into USACE:develop Dec 9, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Location Levels should allow arbitrary units
3 participants