-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 650 - Updated LocationLevel getOne to handle custom units #908
Conversation
I also discovered that the effective date query parameter for getOne is used as the end date in the PL/SQL call. Effectively, any date provided that is after the effective date of the target locationLevel will work to find that locationLevel. This also results in the returned effective date being set to the provided value, not the DB value. Not sure about the impact of this, maybe it should get its own issue? @MikeNeilson |
Sorry, I've re-read this several times and I'm still having difficulty following the issue; I mean it seems like an issue but it's not mapping in my head. Any way to make a simple diagram, flow chart, just plain example data where the issue would be more obvious to myself and others.? |
If I'm following correctly: lets say I pass in today's date, it'll give me back the loc level value from the last effective date (let's say last year), but the DTO returns today's date as the effective date. |
Ah. I see, yeah the correct effective date should be what's in the DTO. |
1fd8b80
to
3e19a62
Compare
Rebased to fix build errors. |
3e19a62
to
2acdae1
Compare
Rebased to fix build issue |
Build errors appear to be unrelated to these changes |
Fixes #650 - Updated LocationLevel getOne to handle custom units and unit systems