Issue 693 - Rating curve retrieval #909
Conversation
| String timezone = ctx.queryParamAsClass(TIMEZONE, String.class).getOrDefault("UTC"); | ||
| Instant date = null; | ||
| String specificDate = ctx.queryParam(EFFECTIVE_DATE); |
There was a problem hiding this comment.
use effectiveDate throughout. it's confusing having this go from EFFECTIVE_DATE, to specificDate, to just "date" in the later code.
There was a problem hiding this comment.
Updated to use effectiveDate and effectiveDateParam for consistency
There was a problem hiding this comment.
While consistency is good, I think this illuminates that the parameter is confusing on this endpoint. I recommend using a separate endpoint. I might be missing a use case where a the closest effective date to a parameter is needed, but given temporal interpolation and transitional dates, that seems to be too complicated.
cwms-data-api/src/main/java/cwms/cda/data/dao/RatingSetDao.java
Outdated
Show resolved
Hide resolved
|
Build failures appear to be unrelated to this PR |
cwms-data-api/src/main/java/cwms/cda/api/RatingLatestController.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/main/java/cwms/cda/data/dao/RatingSetDao.java
Outdated
Show resolved
Hide resolved
Yep, it's the usual failures from other end points. |
cwms-data-api/src/main/java/cwms/cda/api/RatingLatestController.java
Outdated
Show resolved
Hide resolved
cwms-data-api/src/main/java/cwms/cda/data/dao/RatingSetDao.java
Outdated
Show resolved
Hide resolved
Fixes #693 - Adds support for retrieving a rating closest to a specified date.