Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CWMSVue 594 - Added Category and Group office IDs to TimeSeriesGroup and LocationGroup DAOs #949

Merged
merged 6 commits into from
Nov 15, 2024
Merged

CWMSVue 594 - Added Category and Group office IDs to TimeSeriesGroup and LocationGroup DAOs #949

merged 6 commits into from
Nov 15, 2024

Conversation

zack-rma
Copy link
Collaborator

CWMSVue 594 - Added Category and Group office IDs to TimeSeriesGroup and LocationGroup DAOs

zack-rma
zack-rma commented Nov 13, 2024
View reviewed changes
Copy link
Collaborator Author

@zack-rma zack-rma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking for input on the wording of the documentation for the new office id parameters

cwms-data-api/src/main/java/cwms/cda/api/LocationGroupController.java Show resolved Hide resolved
cwms-data-api/src/main/java/cwms/cda/api/TimeSeriesGroupController.java Show resolved Hide resolved
@zack-rma zack-rma requested a review from adamkorynta November 13, 2024 21:09
@zack-rma zack-rma requested a review from adamkorynta November 15, 2024 16:56
@adamkorynta adamkorynta merged commit b5d4356 into USACE:develop Nov 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkorynta adamkorynta adamkorynta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zack-rma @adamkorynta