Devops/build automation #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current failures in the GH build are the same as the teamcity build, tests that we know don't pass; several due to needing that staging version. I will appropriately disable those for now. |
MikeNeilson
requested review from
adamkorynta,
RyanM-RMA,
zack-rma and
rma-rripken
and removed request for
adamkorynta and
RyanM-RMA
|
I may have, by label, incorrectly disabled a few tests, let me know. The ones disabled due to multiple connections definitely need to be fixed, but they do correctly close the connections so in productions not a huge deal. That said the integration tests intentionally run with a pool size of 1 to expose connection usages issues. |
MikeNeilson
added
the
approved-W192HQ23F0232-task4
adamkorynta
reviewed
Dec 9, 2024
adamkorynta
reviewed
Dec 10, 2024
cwms-data-api/src/main/java/cwms/cda/data/dao/location/kind/OutletDao.java
Outdated
Show resolved
Hide resolved
adamkorynta
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new "ready-database" to run the integration tests from github actions.
Updates versioning in build.gradle, calendar versioning, but also supporting tag based so we have some control.
Added an additional Annotation that uses the full schema version (versions, it's a list) to decided if a test should run.