CWMVUE-611 - Adding in endpoint to get time range map for measurments #975
Conversation
rma-bryson
force-pushed
the
feature/CWMSVUE-611_Measurements
branch
from
6876dd0 to
5f57059
Compare
| { | ||
| Timestamp retval = null; | ||
| if(date != null) | ||
| { |
There was a problem hiding this comment.
The curlies on this are wrong.
Also this would probably read easier just doing a return date !=null ? Timestamp.from(date) : null;
There was a problem hiding this comment.
Updated to fix brackets and used a ternary
| @Schema(description = "Last update in the timeseries") | ||
| @JsonFormat(shape = Shape.STRING) | ||
| ZonedDateTime lastUpdate; | ||
|
|
||
| @SuppressWarnings("unused") // required so JAXB can initialize and marshal | ||
| private TimeSeriesExtents() { | ||
| super(new Builder()); |
There was a problem hiding this comment.
This is just... odd.
The constructor should just take a builder and thus both constructors should be private. We appear to be mixing builder/non-builder patterns here and a rather odd way..
There was a problem hiding this comment.
I agree. I tried to preserve the existing TimeSeriesExtents object as much as possible, while making the new TimeExtents object follow the builder pattern of our other dtos. I would be in favor of updating the TimeSeriesExtents to use a builder pattern.
There was a problem hiding this comment.
I updated the TimeSeriesExtents to use a builder pattern for consistency
…. Updated measurement retrieval to use XML api. Fixed issues with quality. Introduced TimeExtents object.
…apis in extending TimeExtents. Code refactor.
Co-authored-by: Mike Neilson <[email protected]>
rma-bryson
force-pushed
the
feature/CWMSVUE-611_Measurements
branch
from
523536a to
9f7984a
Compare
Updated measurement retrieval to use XML api. Fixed issues with quality. Introduced TimeExtents object.