Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another major update to upgrade GDAL to a version from this decade. The docker image now uses the official OSGEO gdal image based on an Ubuntu image. This doesn't really save any size on the docker image as it uses the Ubuntu full to get the netcdf support which is not in the smaller image.
This also updates the requirements to more recent versions which had some minor impacts. Almost all gold files needed to be regenerated but only to update a few attributes with zero impact on the outputs.
Generate topo
vegetation
test folderRan the
gold_difference
script for both Landfire 1.4.0 and 2.0.0. All reported 0 change frommain
.GRM
No impact, tests passed
Delineate
There are the most substantial changes but still fairly minor.
.bna
format. Changing this to an approved format worked, the tests use geojson.The red outline is the old gold file, shaded is the new basin outline, point is the basin outlet from the geojson.