Adds new flows and expands ReCiPe mapping #210

bl-young · 2024-12-04T22:07:06Z

No description provided.

ecoinvent do that in their mapping

…nd/shrubland, respectively This is inspired by what ecoinvent does.

There's more ecoinvent CFs for this flow than FEDEFL ones. (Ecosystem damage ozone formation and Human damage ozone formation). This is easily corrected once we expand the recipe flow nitrogen oxides (as nitrogen dioxide) to Nitrogen Oxides . (Currently it is being expanded to nitrogen dioxide only). This commit does that.

Ecoinvent has a flowable named glufosinate which gets its CFs from the recipe flowable glufosinate-ammonium. FEDEFL's Glufosinate gets its CFs from nowhere, but I think we could expand recipe glufosinate-ammonium to glufosinate as ecoinvent does. This commit does that.

Ecoinvent flowable fenoxaprop-p-ethyl ester gets CFs from recipe fenoxaprop-ethyl. We could maybe do the same and expand fenoxaprop-ethyl eas a proxy to fenoxaprop-p-ethyl.

Recipe Vanadium(V) is currently being mapped to elemental Vanadium only. This expansion is a direct match (recipe V(V) to fedefl Vanadium(V)

Add 'Aldehydes, unspecified' as flowable

Add beta-cyfluthrin as target for cyfluthrin

expand recipe glufosinate-ammonium to FEDEFL glufosinate

expanding recipe nitrogen oxides (as nitrogen dioxide) to fedefl nitrogen oxides

Added proxies to emissions of elementary metals

expand recipe fenoxaprop-ethyl to fedefl fenoxaprop-p-ethyl

pasture and managed forest as proxies for land use grassland/shrubland

expand recipe vanadium(v) to fedefl vanadium(v)

recipe2016: direct expansions for Ba(II), Be(II) and Tin(II)

new flowables and primary contexts from ecoinvent3.10

added external link to new toxic organics.

replicates 3d3a4eb

bnjmnmorelli

@bl-young I am not sure I understand this addition. If you look at the top 8 rows (for example) I understand why Ag (I) air/rural is being mapped to multiple FEDEFL contexts. But why is Ag (I) also being mapped to multiple target flows (Silver (I) and Silver)?

bl-young · 2024-12-05T22:10:17Z

@bl-young I am not sure I understand this addition. If you look at the top 8 rows (for example) I understand why Ag (I) air/rural is being mapped to multiple FEDEFL contexts. But why is Ag (I) also being mapped to multiple target flows (Silver (I) and Silver)?

This was added in #167, which has some discussion there. These LCIA mappings are reversed, in that we can have two flows map to the same CF, if desired. In this case, we are saying that both Silver and Silver(I) should use the ReCiPe CF denoted by Ag(I). Otherwise, as it stands prior to this change, emissions of silver to air are not characterized.

fedelemflowlist/flowmapping/ReCiPe2016.csv

bnjmnmorelli

looks good apart from specific comments.

bnjmnmorelli · 2024-12-05T22:44:40Z

fedelemflowlist/flowmapping/ReCiPe2016.csv

edits in this file look good.

bnjmnmorelli · 2024-12-05T22:45:52Z

fedelemflowlist/flowmapping/openLCA.csv

bnjmnmorelli · 2024-12-05T22:55:07Z

fedelemflowlist/globals.py

bnjmnmorelli · 2024-12-05T22:56:33Z

fedelemflowlist/input/ChemicalsFlowablePrimaryContexts.csv

+"1-(6-tert-butyl-1,1-dimethyl-2,3-dihydroinden-4-yl)ethanone",Emission,Water
+2-(4-chlorophenoxy)-2-methylpropanoic acid,Emission,Water
+2-(4-chlorophenoxy)-2-methylpropanoic acid,Emission,Ground
+"2,2-dichloroacetaldehyde",Emission,Water


@bl-young I notice that quotations are used inconsistently around flowable and synonym names. Presumably both work... Is one preferred?

if there are commas within terms it will automatically add quotation marks

bnjmnmorelli · 2024-12-05T22:56:49Z

fedelemflowlist/input/ChemicalsFlowablePrimaryContexts.csv

bnjmnmorelli · 2024-12-05T22:59:51Z

fedelemflowlist/input/GroupsFlowables.csv

bnjmnmorelli · 2024-12-05T23:01:52Z

fedelemflowlist/input/mapping input/ReCiPe2016ContextMappings.csv

bnjmnmorelli · 2024-12-05T23:03:27Z

scripts/build_lcia_mapping.py

bnjmnmorelli · 2024-12-05T23:03:53Z

fedelemflowlist/input/mapping input/ReCiPe2016FlowableMappings.csv

Not sure why this row is showing as an edit? compare to row above.

a blank line was missing in the prior version (which is why it shows the red mark there and makes it appear like a change

bnjmnmorelli · 2024-12-05T23:04:06Z

fedelemflowlist/input/mapping input/ReCiPe2016FlowableMappings.csv

one comment below. otherwise approve.

fchichorro and others added 30 commits June 20, 2023 09:30

Add beta-cyfluthrin as target for cyfluthrin

1af0fdf

ecoinvent do that in their mapping

Add recipe pasture and managed forest as proxies for land use grassla…

48e8263

…nd/shrubland, respectively This is inspired by what ecoinvent does.

Added proxies to emissions of elementary metals

4505c78

Added 'Aldehydes, unspecified' as flowable

7b103e0

expand recipe fenoxaprop-ethyl to fedefl fenoxaprop-p-ethyl

ba7db7e

Ecoinvent flowable fenoxaprop-p-ethyl ester gets CFs from recipe fenoxaprop-ethyl. We could maybe do the same and expand fenoxaprop-ethyl eas a proxy to fenoxaprop-p-ethyl.

expand recipe vanadium(v) to fedefl vanadium(v)

20825e1

Recipe Vanadium(V) is currently being mapped to elemental Vanadium only. This expansion is a direct match (recipe V(V) to fedefl Vanadium(V)

Merge pull request #163 from fchichorro/add_aldehydes_unspecified

d947efe

Add 'Aldehydes, unspecified' as flowable

Merge pull request #165 from fchichorro/beta_cyfluthrin

9a0afc2

Add beta-cyfluthrin as target for cyfluthrin

Merge pull request #169 from fchichorro/glufosinate_ammonium

24d7d1c

expand recipe glufosinate-ammonium to FEDEFL glufosinate

Merge pull request #168 from fchichorro/nitrogen_oxides

50d3b5e

expanding recipe nitrogen oxides (as nitrogen dioxide) to fedefl nitrogen oxides

Merge pull request #167 from fchichorro/elementary_metals_proxies

82e8dd8

Added proxies to emissions of elementary metals

Merge pull request #171 from fchichorro/fenoxaprop-p-ethyl

e690e03

expand recipe fenoxaprop-ethyl to fedefl fenoxaprop-p-ethyl

add in flowable mappings and re-generate mapping file

30771be

Merge pull request #166 from fchichorro/land_use_extensions

8816583

pasture and managed forest as proxies for land use grassland/shrubland

update input files and regenerate mapping file

ab561f0

Merge pull request #173 from fchichorro/vanadium-v

ff9fdc4

expand recipe vanadium(v) to fedefl vanadium(v)

update input files and regenerate mapping file

fce4d75

Merge branch 'develop' into flow_updates

64352d7

new flowables and primary contexts from ecoinvent3.10

8527935

ecoinvent<=3.9.1 flowables

27dece6

recipe2016: direct expansions for Ba(II), Be(II) and Tin(II)

11e9fa2

Merge branch 'develop' into flow_updates

6b21498

Merge branch 'flow_updates' into recipe2016/barium_beryllium_tin

bb1b5c0

Merge pull request #187 from fchichorro/recipe2016/barium_beryllium_tin

78f8d61

recipe2016: direct expansions for Ba(II), Be(II) and Tin(II)

Merge pull request #186 from fchichorro/ecoinvent3.10/new_flowables

ceb8c2b

new flowables and primary contexts from ecoinvent3.10

add toxic organics, #202

423400e

Update ChemicalsFlowables.csv

b260c76

added external link to new toxic organics.

update copper sulfide spelling

d2e3ebb

replicates 3d3a4eb

bl-young added 3 commits December 4, 2024 09:13

update copper sulfide spelling for primary contexts

e74c494

update copper sulfide spelling in mapping file

1d13c74

update UUID for copper sulfide in mapping file

783fb10

bl-young added this to the v1.3.0 milestone Dec 4, 2024

bl-young requested a review from bnjmnmorelli December 4, 2024 22:32

bl-young added 2 commits December 4, 2024 18:54

Merge branch 'develop' into flow_updates

104c50b

resolve incompatible dtype FutureWarning

78dc3a6

This comment was marked as off-topic.

Sign in to view

bnjmnmorelli reviewed Dec 5, 2024

View reviewed changes

fedelemflowlist/flowmapping/ReCiPe2016.csv Outdated Show resolved Hide resolved

bnjmnmorelli approved these changes Dec 5, 2024

View reviewed changes

bl-young marked this pull request as ready for review December 6, 2024 02:25

bl-young merged commit 9c6a0a7 into develop Dec 6, 2024
18 checks passed

bl-young deleted the flow_updates branch December 6, 2024 02:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds new flows and expands ReCiPe mapping #210

Adds new flows and expands ReCiPe mapping #210

bl-young commented Dec 4, 2024

This comment was marked as off-topic.

bnjmnmorelli left a comment

bl-young commented Dec 5, 2024

bnjmnmorelli left a comment

bnjmnmorelli Dec 5, 2024

bnjmnmorelli Dec 5, 2024

bnjmnmorelli Dec 5, 2024

bnjmnmorelli Dec 5, 2024

bl-young Dec 6, 2024

bnjmnmorelli Dec 5, 2024

bnjmnmorelli Dec 5, 2024

bnjmnmorelli Dec 5, 2024

bnjmnmorelli Dec 5, 2024

bnjmnmorelli Dec 5, 2024 •

edited

Loading

bl-young Dec 6, 2024

bnjmnmorelli Dec 5, 2024

Adds new flows and expands ReCiPe mapping #210

Adds new flows and expands ReCiPe mapping #210

Conversation

bl-young commented Dec 4, 2024

This comment was marked as off-topic.

bnjmnmorelli left a comment

Choose a reason for hiding this comment

bl-young commented Dec 5, 2024

bnjmnmorelli left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bnjmnmorelli Dec 5, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bnjmnmorelli Dec 5, 2024 •

edited

Loading