Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CoC committee 2023 #1288

Merged
merged 5 commits into from
Oct 13, 2023
Merged

Conversation

jbteves-sandia
Copy link
Contributor

Description

Adds the current CoC committee on the CoC page

Checklist:

  • I have previewed changes locally or with CircleCI (runs when PR is created)
  • I have completed any content reviews, such as getting input from relevant working groups. If no, please note this and wait to post the PR to the #website channel until the content has been settled.

When you are ready for a technical review/merge, post the for the link for the PR in the US-RSE Slack (#website) to ask for reviewers.

Copy link
Contributor

@lrasmus lrasmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor items - not sure why the mailto: link isn't rendering. Because it's within other HTML code, maybe we need to use <a href instead of markdown syntax?

<li> David Nicholson</li>
<li> Joshua Teves</li>
</ul>
You may reach any of them on the US-RSE slack individually or email [coc@us-rse](mailto:[email protected]) in order to contact them.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The mailto: email address (display text) is missing ".org" and doesn't match the actual mailto address.
  2. The mailto: link isn't rendering properly in the preview for some reason.
  3. I would suggest capitalizing "Slack" and consider adding a link to the Slack directly (removed about adding link to Slack, doesn't seem that it's done throughout the website).

<p>
The current Code of Conduct Committee consists of:
<ul>
<li> Lezlie Espana</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Lezlie, should last name be spelled "España" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's correct, thank you!

Copy link
Contributor

@lrasmus lrasmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cmaimone
Copy link
Contributor

Not sure why, but the code of conduct page doesn't have a preview: https://output.circle-artifacts.com/output/job/5cbd58f5-ff3d-4be4-ac40-73a5b2f27a51/artifacts/0/usrse.github.io/about/code-of-conduct/ - that seems concerning

@lrasmus
Copy link
Contributor

lrasmus commented Oct 13, 2023

@cmaimone - it seems like it's auto-redirecting to that from https://output.circle-artifacts.com/output/job/5cbd58f5-ff3d-4be4-ac40-73a5b2f27a51/artifacts/0/usrse.github.io/about/code-of-conduct/index.html (which does preview)

@@ -34,3 +34,13 @@ $(document).ready(function(){

});
</script>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a header here - Code of Conduct Committee perhaps

@cmaimone cmaimone merged commit 6f6dbf5 into USRSE:main Oct 13, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants