-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CoC committee 2023 #1288
Add CoC committee 2023 #1288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor items - not sure why the mailto: link isn't rendering. Because it's within other HTML code, maybe we need to use <a href
instead of markdown syntax?
pages/about/code-of-conduct.md
Outdated
<li> David Nicholson</li> | ||
<li> Joshua Teves</li> | ||
</ul> | ||
You may reach any of them on the US-RSE slack individually or email [coc@us-rse](mailto:[email protected]) in order to contact them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The mailto: email address (display text) is missing ".org" and doesn't match the actual mailto address.
- The mailto: link isn't rendering properly in the preview for some reason.
- I would suggest capitalizing "Slack"
and consider adding a link to the Slack directly(removed about adding link to Slack, doesn't seem that it's done throughout the website).
pages/about/code-of-conduct.md
Outdated
<p> | ||
The current Code of Conduct Committee consists of: | ||
<ul> | ||
<li> Lezlie Espana</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Lezlie, should last name be spelled "España" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's correct, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Not sure why, but the code of conduct page doesn't have a preview: https://output.circle-artifacts.com/output/job/5cbd58f5-ff3d-4be4-ac40-73a5b2f27a51/artifacts/0/usrse.github.io/about/code-of-conduct/ - that seems concerning |
@cmaimone - it seems like it's auto-redirecting to that from https://output.circle-artifacts.com/output/job/5cbd58f5-ff3d-4be4-ac40-73a5b2f27a51/artifacts/0/usrse.github.io/about/code-of-conduct/index.html (which does preview) |
@@ -34,3 +34,13 @@ $(document).ready(function(){ | |||
|
|||
}); | |||
</script> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a header here - Code of Conduct Committee perhaps
Description
Adds the current CoC committee on the CoC page
Checklist:
When you are ready for a technical review/merge, post the for the link for the PR in the US-RSE Slack (#website) to ask for reviewers.