Skeleton Hotfix #708
Skeleton Hotfix #708
Conversation
|
Vercel Preview URL 🚀 : https://planner-j4xsyim9k-utdnebula.vercel.app |
|
Vercel Preview URL 🚀 : https://planner-qia4bszxp-utdnebula.vercel.app |
| @@ -151,7 +151,7 @@ export const MemoizedSemesterCourseItem = React.memo( | |||
| )} | |||
| </span> | |||
| <span className="truncate text-sm"> | |||
| {title || (course.code[0] == '0' ? '' : <Skeleton />)} | |||
| {title || (course.code[0] == '0' || course.code.includes("Elective") ? '' : <Skeleton />)} | |||
There was a problem hiding this comment.
Could you write a quick comment explaining the fix?
There was a problem hiding this comment.
Right now, the skeleton for the course title appears based on whether or not 'title' is defined. Problem is that on a degree template, some "courses" don't have titles (placeholders like "060 Course" or "CS Guided Elective") and the skeleton on those is always there. So right now I'm just doing a check on both the existence of a title and checking if the course code isn't one of the placeholders.
There was a problem hiding this comment.
It may make sense for this to be included as a comment in the code.
Jake3231
requested review from
a team and
kamui-fin
and removed request for
a team
The skeleton lasts forever on template courses like 'CS Guided Elective Course', this fixes that